major(core|persisted): use GET for queries by default#3789
Merged
JoviDeCroock merged 2 commits intomainfrom Aug 9, 2025
Merged
major(core|persisted): use GET for queries by default#3789JoviDeCroock merged 2 commits intomainfrom
JoviDeCroock merged 2 commits intomainfrom
Conversation
kitten
approved these changes
Jun 29, 2025
Member
There was a problem hiding this comment.
I think it's fair to push for this and change the default here.
This also enables us to look at what we can do to make this behaviour more expected in core.
Typically, query-level approaches omit the AST. We'll have to look at how we can deal with the lack of the AST, or rather, enforce that it's still there if a cache (or other logic) expects it.
Basically, we can be more explicit about:
persistedExchangebehaviour (potentially in core)- how exchanges deal with a missing document (explicit incompatibilities)
- how exchanges deal with a document + hash (explicitly disallow modifications via freezes in development)
Merged
3 tasks
arkandias
pushed a commit
to arkandias/urql
that referenced
this pull request
Aug 10, 2025
1 task
grossmannmartin
added a commit
to shopsys/shopsys
that referenced
this pull request
Oct 17, 2025
- effectively disables behavior introduced in urql-graphql/urql#3789
1 task
grossmannmartin
added a commit
to shopsys/shopsys
that referenced
this pull request
Oct 17, 2025
- effectively disables behavior introduced in urql-graphql/urql#3789
grossmannmartin
added a commit
to shopsys/shopsys
that referenced
this pull request
Oct 20, 2025
- effectively disables behavior introduced in urql-graphql/urql#3789
grossmannmartin
added a commit
to shopsys/shopsys
that referenced
this pull request
Oct 21, 2025
- effectively disables behavior introduced in urql-graphql/urql#3789
ShopsysBot
pushed a commit
to shopsys/project-base
that referenced
this pull request
Oct 21, 2025
- effectively disables behavior introduced in urql-graphql/urql#3789
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've been thinking about this for quite a while but it's time that this default is switched up, most GraphQL clients force you in this paradigm of always leveraging POST which misses out on a lot of benefits. The settings to actually do it the "right way" HTTP semantically is hidden behind an option.
The downside is that some servers might not support GET, however they are still free to turn this off. I prefer the explicit having to turn it off from having a degraded default experience.
The default should still be persisted operations but at least we take a step forward HTTP semantically wise.