Add installation instructions for gfmrun#2177
Merged
dearchap merged 2 commits intourfave:mainfrom Aug 9, 2025
Merged
Conversation
Juneezee
approved these changes
Aug 9, 2025
dearchap
reviewed
Aug 9, 2025
dearchap
approved these changes
Aug 9, 2025
Member
|
I think I'd like to address this documentation bug a bit differently since the Lines 98 to 101 in 3976dfc cli/.github/workflows/publish-docs.yml Line 33 in 3976dfc |
Contributor
Author
|
@meatballhat's suggestion seems reasonable to me, based on my understanding of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Contributor docs did not include that
gfmrunis a dependency for runningmake all. The PR adds a few lines with instructions on doing that.Special notes for your reviewer:
This is my first PR for this repo. Any suggestions - or a correction if I'm off base here - would be helpful.
Testing
On a machine that does not have
gfmrun, run:Run
Final steps should fail.
Now run installation described in PR:
Re-run
Final steps should pass.
Release Notes