feat(preset-web-fonts): add fetch option to LocalFontProcessor#4894
Merged
zyyv merged 2 commits intounocss:mainfrom Aug 30, 2025
Merged
feat(preset-web-fonts): add fetch option to LocalFontProcessor#4894zyyv merged 2 commits intounocss:mainfrom
zyyv merged 2 commits intounocss:mainfrom
Conversation
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
4 tasks
antfu
reviewed
Aug 21, 2025
| /** | ||
| * Custom fetch function to provide the font data. | ||
| */ | ||
| customFetch?: (url: string) => Promise<any> |
Member
There was a problem hiding this comment.
Suggested change
| customFetch?: (url: string) => Promise<any> | |
| fetch?: typeof fetch |
|
commit: |
zyyv
approved these changes
Aug 30, 2025
This was referenced Aug 31, 2025
This was referenced Aug 31, 2025
This was referenced Sep 8, 2025
This was referenced Sep 16, 2025
This was referenced Sep 25, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #4886
Overview
This PR resolves issue #4886 where
_downloadFontin the LocalFontProcessor was hardcoded to use the defaultofetchinstead of adding thefetchoption.This prevented font downloading when using proxy configurations.
Scope of Work
fetchproperty toLocalFontProcessorOptionsinterfaceoptions?.fetch ?? fetchto suppor fetch implementationsExample Usage
This is my first PR for Unocss. If you have any feedback or suggestions, please let me know.