fix(autocomplete): respect variant autocomplete template without mutipass#4891
Merged
fix(autocomplete): respect variant autocomplete template without mutipass#4891
mutipass#4891Conversation
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
zyyv
commented
Aug 20, 2025
| }) | ||
|
|
||
| it('should skip single-pass variants', async () => { | ||
| expect(await ac.suggest('dark:dar')).not.toContain('dark:') |
Member
Author
There was a problem hiding this comment.
I think there is no need to skip not mutipass variants. Such errors should be returned to the user themselves. We should provide them, and users can choose not to select them. Otherwise, all non-mutipass variant templates will become invalid.
This was referenced Sep 2, 2025
This was referenced Sep 10, 2025
This was referenced Sep 18, 2025
This was referenced Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think autocomplete should fully parse the existing template, regardless of the internal logic.