feat!: provider specific options in resolveFont#288
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 11 11
Lines 516 520 +4
Branches 132 134 +2
=======================================
+ Hits 511 515 +4
Misses 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/index.ts
Outdated
| ResolveFontOptions<{ | ||
| [K in T[number] as K['_name']]?: ExtractFamilyOptions<K>; | ||
| }> |
There was a problem hiding this comment.
This would be different with #287: instead of having eg. { google?: A; fontsource?: B }, you'd only have A when resolving the google provider.
Depending on which PR is merged first, I'll adapt the other one accordingly
|
If you think removing the provider options is too disruptive, there's a solution: keep the top level options and override with family specific options |
|
@danielroe this is ready for your review! I'd like to get this merged this week if possible |
|
Much better, thanks for the feedback! |
resolveFont()directlydefineFontProvideris updated to optionally be used with currying. I chose this API because