Conversation
sjinks
commented
Aug 2, 2025
pi0
reviewed
Aug 3, 2025
node: specifiers
pi0
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #391
This pull request refactors the
jitiRequirefunction insrc/require.tsto resolve the issue with detecting prefix-only built-in modules, such asnode:test.I'd love to add tests, but I was unable to find any that deal with the
node:protocol.To test:
test.mts:Run:
Without this patch, a
MODULE_NOT_FOUNDerror will occur.With this patch, the script will successfully run.