Skip to content

chore: add defaults in JSDocs#365

Merged
pi0 merged 3 commits intounjs:mainfrom
aryaemami59:chore/add-jsdoc-defaults
Mar 7, 2025
Merged

chore: add defaults in JSDocs#365
pi0 merged 3 commits intounjs:mainfrom
aryaemami59:chore/add-jsdoc-defaults

Conversation

@aryaemami59
Copy link
Copy Markdown
Contributor

No description provided.

@aryaemami59 aryaemami59 self-assigned this Feb 12, 2025
@aryaemami59 aryaemami59 force-pushed the chore/add-jsdoc-defaults branch 5 times, most recently from b3f9b4f to 87c8d2c Compare February 12, 2025 08:44
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid unrelated changes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are necessary to get the CI to pass. If you wanna push these on main as well, then I can revert them here.

@aryaemami59 aryaemami59 force-pushed the chore/add-jsdoc-defaults branch from 87c8d2c to 15481f6 Compare February 12, 2025 12:34
@aryaemami59 aryaemami59 requested a review from pi0 February 12, 2025 14:22
@aryaemami59 aryaemami59 marked this pull request as ready for review February 28, 2025 14:35
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@pi0 pi0 merged commit b396aec into unjs:main Mar 7, 2025
7 checks passed
@aryaemami59 aryaemami59 deleted the chore/add-jsdoc-defaults branch March 7, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants