Merged
Conversation
…ng processed as folder Branch name: feat/resolve-config-files-wo-extensions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 76.92% 78.36% +1.44%
==========================================
Files 7 6 -1
Lines 806 638 -168
Branches 80 130 +50
==========================================
- Hits 620 500 -120
+ Misses 184 138 -46
+ Partials 2 0 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This change will load /cc @userquin Oops sorry for the ping, this was already reported and being discussed in #275 |
pi0
added a commit
that referenced
this pull request
Oct 17, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch name: feat/resolve-config-files-wo-extensions
resolves #267
This pull request enhances the configuration loader to support resolving config files from relative paths that do not correspond to folders, and adds tests to verify this new behavior. The changes ensure that configs like
./not-a-folderare correctly loaded even if the path points to a file rather than a directory.Config resolution improvements:
resolveConfiginsrc/loader.tsto attempt resolving config files using the original source path, enabling support for relative file paths that are not folders. [1] [2]Test coverage for new resolution logic:
./not-a-folderto theextendsarray intest/fixture/.config/test.tsto test the new resolution behavior. [1] [2]test/fixture/not-a-folder.tsto serve as the target for the new test case.test/loader.test.tsto check that thenot_a_folderconfig is correctly loaded and included in the resolved config layers. [1] [2]