JSpecify: handle varargs whose element type is a type variable#1200
Merged
JSpecify: handle varargs whose element type is a type variable#1200
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
============================================
+ Coverage 88.19% 88.21% +0.02%
- Complexity 2310 2317 +7
============================================
Files 88 88
Lines 7564 7577 +13
Branches 1510 1513 +3
============================================
+ Hits 6671 6684 +13
Misses 448 448
Partials 445 445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxincs
approved these changes
Apr 18, 2025
dhruv-agr
pushed a commit
to dhruv-agr/NullAway
that referenced
this pull request
May 9, 2025
…1200) Partially addresses uber#1199. After substituting for a type variable, we were not retrieving the correct nullability for a varargs parameter, which should be the nullability of the component, not the array type itself. Also adds some simplification of our handling of varargs calls based on a tip from @jeffrey-easyesi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1199. After substituting for a type variable, we were not retrieving the correct nullability for a varargs parameter, which should be the nullability of the component, not the array type itself.
Also adds some simplification of our handling of varargs calls based on a tip from @jeffrey-easyesi