Use /usr/bin/env sh instead of direct path of sh by skhaz · Pull Request #1051 · typicode/husky

skhaz · 2021-09-24T18:46:04Z

According with the best practices of shell scripting, the right way to invoke the shebang is #!/usr/bin/env shell

Reference: https://www.cyberciti.biz/tips/finding-bash-perl-python-portably-using-env.html

Maxim-Mazurok · 2021-09-27T03:48:44Z

This doesn't work in my Ubuntu 20 (WSL):

$ /usr/bin/env shell
/usr/bin/env: ‘shell’: No such file or directory

Maxim-Mazurok · 2021-09-27T04:12:11Z

I wanted to use bash, this worked for me:

# Bash sets the BASH environment variable, so if it is not set, then we
# are running in a different shell, so manually run ourselves in BASH.
# source: https://github.com/typicode/husky/issues/971#issuecomment-846431179
if [ -z "${BASH:-}" ]; then
  exec bash "$0" "$@"
fi

Credit: #971 (comment)

nathandao · 2021-09-27T06:21:51Z

This doesn't work in my Ubuntu 20 (WSL):
$ /usr/bin/env shell
/usr/bin/env: ‘shell’: No such file or directory

hmmm, does using /usr/bin/env sh instead of shell work for you? 🤔

nathandao · 2021-09-27T08:21:50Z

@skhaz since you're already on it, would it be possible to update other parts of the code that are using #!/bin/sh as well? The files I found are:

.husky/commit-msg
.husky/pre-commit
docs/README.md
./husky.sh

Maxim-Mazurok · 2021-09-27T12:19:04Z

This doesn't work in my Ubuntu 20 (WSL):
$ /usr/bin/env shell
/usr/bin/env: ‘shell’: No such file or directory
hmmm, does using /usr/bin/env sh instead of shell work for you? 🤔

Yes, it does. Opens up sh for me. Same with /usr/bin/env bash - opens up bash for me.

Maxim-Mazurok · 2021-09-27T12:21:10Z

Also, I can see that in the linked article they mention #!/usr/bin/env bash not #!/usr/bin/env shell:

Let us find out why is it a good idea to use #!/usr/bin/env bash instead of #!/bin/bash as shebang?
(source)

So, I guess that it was a typo, @skhaz?

skhaz · 2021-09-27T13:34:28Z

@Maxim-Mazurok do you want bash instead of sh? I am not sure if macOS cames with bash, sh is a more secure option

skhaz · 2021-09-27T13:35:08Z

@nathandao done, changed all references of /bin/sh

Maxim-Mazurok · 2021-09-27T14:08:31Z

@Maxim-Mazurok do you want bash instead of sh? I am not sure if macOS cames with bash, sh is more secure option

Yes, I want bash because I am letting developers configure if they want to lint and unit test their code in pre-commit hook. I'm storing scrips in array, and then passing this array of scripts to npm-run-all. Didn't find an easy way to do this with sh. Also, I'm only concerned about Ubuntu and Windows. And windows git client comes with git bash, so I guess it's pretty safe for me. Mac may think differently ;)

Maxim-Mazurok · 2021-09-27T14:13:15Z

This is my code:

scripts=("npm:sort -- --check" "npm:spell-check" "npm:prettier:check")
[[ "$PRE_COMMIT_LINT" == true ]] && scripts+=("npm:test:lint")
[[ "$PRE_COMMIT_TEST_UNIT" == true ]] && scripts+=("npm:test:unit")
npx -y concurrently --kill-others-on-fail "${scripts[@]}"

But sh/bash is not related to this ~~issue~~ PR, so never mind :)

skhaz · 2021-09-27T14:26:32Z

@Maxim-Mazurok you can use bash by invoking the script inside the hook, for example:

Your hook

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

your_script.sh || exit

And in your_script.sh you have bash specific things:

#!/bin/bash

your code for bash

Or... Manually change to bash your hook

Maxim-Mazurok · 2021-09-29T01:49:40Z

Or... Manually change to bash your hook

This doesn't work (changing shebang in hook), because husky.sh resets shell to be sh.

@Maxim-Mazurok you can use bash by invoking the script inside the hook, for example:

Your hook
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

your_script.sh || exit
And in your_script.sh you have bash specific things:
#!/bin/bash

your code for bash

This is a good idea, thanks

stale · 2021-11-28T22:27:26Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Maxim-Mazurok · 2021-11-28T23:01:45Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Occuring an activity

skhaz · 2021-11-29T02:01:58Z

Bump

stale · 2022-01-28T02:05:38Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Maxim-Mazurok · 2022-01-28T02:24:41Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Occuring an activity

typicode · 2022-02-17T05:55:23Z

Thank you for the PR 👍

Use /usr/bin/env sh instead of direct path of sh

bda8b94

stale Bot added the wontfix label Nov 28, 2021

stale Bot removed the wontfix label Nov 28, 2021

devinrhode2 mentioned this pull request Dec 29, 2021

Use /usr/bin/env sh instead of direct path lint-staged/lint-staged#1020

Merged

stale Bot added the wontfix label Jan 28, 2022

stale Bot removed the wontfix label Jan 28, 2022

typicode merged commit 81b2e2e into typicode:main Feb 17, 2022

typicode mentioned this pull request Feb 17, 2022

Do not depend on the exact location of the 'sh' interpreter #1089

Closed

typicode mentioned this pull request Mar 3, 2022

Directly re-execute the current script #1111

Closed

ajfisher mentioned this pull request May 9, 2022

chore(deps-dev): bump husky from 7.0.4 to 8.0.1 nodebots/nodebots-interchange#259

Merged

This was referenced Jun 1, 2022

Update dependency husky to v8 - autoclosed keplr-team/eslint-config-backend-node#140

Closed

Update dependency husky to v8 - autoclosed keplr-team/typed-ajv#353

Closed

sync-by-unito Bot mentioned this pull request Jun 1, 2022

build(deps-dev): bump husky from 7.0.2 to 8.0.1 numbersprotocol/capture-cam#1671

Closed

Fdawgs mentioned this pull request Aug 31, 2022

chore(.husky): shell path and arg updates pinojs/sonic-boom#156

Merged

Uh oh!

Conversation

skhaz commented Sep 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Maxim-Mazurok commented Sep 27, 2021

Uh oh!

Maxim-Mazurok commented Sep 27, 2021

Uh oh!

nathandao commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nathandao commented Sep 27, 2021

Uh oh!

Maxim-Mazurok commented Sep 27, 2021

Uh oh!

Maxim-Mazurok commented Sep 27, 2021

Uh oh!

skhaz commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skhaz commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Maxim-Mazurok commented Sep 27, 2021

Uh oh!

Maxim-Mazurok commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skhaz commented Sep 27, 2021

Uh oh!

Maxim-Mazurok commented Sep 29, 2021

Uh oh!

stale Bot commented Nov 28, 2021

Uh oh!

Maxim-Mazurok commented Nov 28, 2021

Uh oh!

skhaz commented Nov 29, 2021

Uh oh!

stale Bot commented Jan 28, 2022

Uh oh!

Maxim-Mazurok commented Jan 28, 2022

Uh oh!

typicode commented Feb 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

skhaz commented Sep 24, 2021 •

edited

Loading

nathandao commented Sep 27, 2021 •

edited

Loading

skhaz commented Sep 27, 2021 •

edited

Loading

skhaz commented Sep 27, 2021 •

edited

Loading

Maxim-Mazurok commented Sep 27, 2021 •

edited

Loading