#11920 move mypy config to pyproject.toml#11921
Merged
graingert merged 3 commits intotwisted:trunkfrom Aug 28, 2023
Merged
Conversation
graingert
commented
Aug 18, 2023
Comment on lines
+579
to
+618
| [[tool.mypy.overrides]] | ||
| allow_untyped_defs = true | ||
| module = [ | ||
| 'twisted.application.test.test_service', | ||
| 'twisted.python._pydoctor', | ||
| 'twisted.python._release', | ||
| 'twisted.python._shellcomp', | ||
| 'twisted.python._textattributes', | ||
| 'twisted.python.compat', | ||
| 'twisted.python.components', | ||
| 'twisted.python.context', | ||
| 'twisted.python.deprecate', | ||
| 'twisted.python.fakepwd', | ||
| 'twisted.python.htmlizer', | ||
| 'twisted.python.lockfile', | ||
| 'twisted.python.log', | ||
| 'twisted.python.monkey', | ||
| 'twisted.python.procutils', | ||
| 'twisted.python.randbytes', | ||
| 'twisted.python.release', | ||
| 'twisted.python.roots', | ||
| 'twisted.python.shortcut', | ||
| 'twisted.python.syslog', | ||
| 'twisted.python.test.test_dist3', | ||
| 'twisted.python.test.test_htmlizer', | ||
| 'twisted.python.test.test_runtime', | ||
| 'twisted.python.test.test_setup', | ||
| 'twisted.python.test.test_textattributes', | ||
| 'twisted.python.test.test_tzhelper', | ||
| 'twisted.python.test.test_versions', | ||
| 'twisted.python.test.test_win32', | ||
| 'twisted.python.test.test_zippath', | ||
| 'twisted.python.threadpool', | ||
| 'twisted.python.zippath', | ||
| 'twisted.runner.inetdtap', | ||
| 'twisted.runner.procmontap', | ||
| 'twisted.runner.inetdconf', | ||
| 'twisted.runner.test.test_procmontap', | ||
| ] | ||
|
|
Member
Author
There was a problem hiding this comment.
Suggested change
| [[tool.mypy.overrides]] | |
| allow_untyped_defs = true | |
| module = [ | |
| 'twisted.application.test.test_service', | |
| 'twisted.python._pydoctor', | |
| 'twisted.python._release', | |
| 'twisted.python._shellcomp', | |
| 'twisted.python._textattributes', | |
| 'twisted.python.compat', | |
| 'twisted.python.components', | |
| 'twisted.python.context', | |
| 'twisted.python.deprecate', | |
| 'twisted.python.fakepwd', | |
| 'twisted.python.htmlizer', | |
| 'twisted.python.lockfile', | |
| 'twisted.python.log', | |
| 'twisted.python.monkey', | |
| 'twisted.python.procutils', | |
| 'twisted.python.randbytes', | |
| 'twisted.python.release', | |
| 'twisted.python.roots', | |
| 'twisted.python.shortcut', | |
| 'twisted.python.syslog', | |
| 'twisted.python.test.test_dist3', | |
| 'twisted.python.test.test_htmlizer', | |
| 'twisted.python.test.test_runtime', | |
| 'twisted.python.test.test_setup', | |
| 'twisted.python.test.test_textattributes', | |
| 'twisted.python.test.test_tzhelper', | |
| 'twisted.python.test.test_versions', | |
| 'twisted.python.test.test_win32', | |
| 'twisted.python.test.test_zippath', | |
| 'twisted.python.threadpool', | |
| 'twisted.python.zippath', | |
| 'twisted.runner.inetdtap', | |
| 'twisted.runner.procmontap', | |
| 'twisted.runner.inetdconf', | |
| 'twisted.runner.test.test_procmontap', | |
| ] |
pretty sure this config block is redundant
Member
There was a problem hiding this comment.
Feel free to delete this.
As long as mypy check is green, this should be ok.
Thanks
Member
Author
There was a problem hiding this comment.
I'll do this in a follow up I think
adiroiban
approved these changes
Aug 28, 2023
Member
adiroiban
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
Please merge as you want :)
Comment on lines
+579
to
+618
| [[tool.mypy.overrides]] | ||
| allow_untyped_defs = true | ||
| module = [ | ||
| 'twisted.application.test.test_service', | ||
| 'twisted.python._pydoctor', | ||
| 'twisted.python._release', | ||
| 'twisted.python._shellcomp', | ||
| 'twisted.python._textattributes', | ||
| 'twisted.python.compat', | ||
| 'twisted.python.components', | ||
| 'twisted.python.context', | ||
| 'twisted.python.deprecate', | ||
| 'twisted.python.fakepwd', | ||
| 'twisted.python.htmlizer', | ||
| 'twisted.python.lockfile', | ||
| 'twisted.python.log', | ||
| 'twisted.python.monkey', | ||
| 'twisted.python.procutils', | ||
| 'twisted.python.randbytes', | ||
| 'twisted.python.release', | ||
| 'twisted.python.roots', | ||
| 'twisted.python.shortcut', | ||
| 'twisted.python.syslog', | ||
| 'twisted.python.test.test_dist3', | ||
| 'twisted.python.test.test_htmlizer', | ||
| 'twisted.python.test.test_runtime', | ||
| 'twisted.python.test.test_setup', | ||
| 'twisted.python.test.test_textattributes', | ||
| 'twisted.python.test.test_tzhelper', | ||
| 'twisted.python.test.test_versions', | ||
| 'twisted.python.test.test_win32', | ||
| 'twisted.python.test.test_zippath', | ||
| 'twisted.python.threadpool', | ||
| 'twisted.python.zippath', | ||
| 'twisted.runner.inetdtap', | ||
| 'twisted.runner.procmontap', | ||
| 'twisted.runner.inetdconf', | ||
| 'twisted.runner.test.test_procmontap', | ||
| ] | ||
|
|
Member
There was a problem hiding this comment.
Feel free to delete this.
As long as mypy check is green, this should be ok.
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #11920