Merged
Conversation
fabpot
commented
Jan 14, 2026
Comment on lines
+43
to
+46
| $right = match ($this->getName()) { | ||
| '=' => $right, | ||
| default => throw new \LogicException(\sprintf('Unknown operator: %s.', $this->getName())), | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
This could be simplified, but I'd maybe add more assignment operators in another PR.
d2f86d5 to
c68c1ce
Compare
smnandre
reviewed
Jan 17, 2026
| if (!\is_string($name)) { | ||
| throw new \LogicException('The "name" attribute must be a string.'); | ||
| } | ||
| $left = new AssignContextVariable($name, $left->getTemplateLine()); |
Contributor
There was a problem hiding this comment.
Are you not bypassing the AssignNameExpression checks (ensuring "name" is different of "false" "true" ... ) Not about their role right now :)
Contributor
Author
There was a problem hiding this comment.
I don't get your comment, can you clarify?
Contributor
There was a problem hiding this comment.
To be honest, not sure I still can right. This now seems perfectly clear.. #insomnia
c68c1ce to
7e62c75
Compare
7e62c75 to
bfbbef0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.