Conversation
|
hi... isn´t it more like percentage(divide(1, $count))? cause 100 gives eg. 333.33333% back. |
Yes you are right. I changed it ad76686 Now the percentages are correct. |
louismaximepiton
left a comment
There was a problem hiding this comment.
Looks good to me.
Thanks for the contribution!
|
So to use Bootstrap in a project including this pull request, you can either use: |
|
Bootstrap v4.6 has the same issue |
|
@twbs/css-review we might also need to backport the fix in the rfs repo. If someone fixes the issue there, please CC me. |
julien-deramond
left a comment
There was a problem hiding this comment.
LGTM!
16.6666666667%; becomes 16.66666667%; and 33.3333333333%; becomes 33.33333333%; but this precision is enough (already used in bootstrap.css in other contexts).
|
Another possibility is the following tested by @louismaximepiton (https://github.com/twbs/bootstrap/compare/main-lmp-abs-warning-fix + fix in |
|
Can you please make a PR? Note that we need the RFS change made upstream
when we decide which patch to land here.
…On Thu, Aug 31, 2023, 08:51 Julien Déramond ***@***.***> wrote:
Another possibility is the following tested by @louismaximepiton
<https://github.com/louismaximepiton> (
https://github.com/twbs/bootstrap/compare/main-lmp-abs-warning-fix) which
would make it transparent even for folks using divide() in their own
context/project.
—
Reply to this email directly, view it on GitHub
<#39030 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNMS7RIJIDK2UWLJRKLXYAQ65ANCNFSM6AAAAAA3LMXJCM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
We tried something via #39132 but fixing I suggest that we merge + ship this patch. And then, if we get rid of the It means that there would be nothing to do for now in @twbs/css-review all fine with this proposal? Thoughts? |
Forked from v4 tag. Based on twbs#39030
|
@julien-deramond any chance to see this patch backported in BS 4.x? |
|
@n-rodriguez Bootstrap 4 has been EOL since 2023-01-01, so unfortunately there won't be a patch backported to it. |
Description
Fix the deprecation warning with dart-sass. See #39028
Type of changes
Checklist
npm run lint)Related issues
Fixes #39028