Increase contrast in dark-mode (#38525)#38815
Merged
Conversation
This increases the default brightness for the body text-color in dark mode, which inceases readability a bit. It was also suggested to darken the background a bit, but we unfortunately don't have a darker gray in our color palette. So for now, let's increase the text-color by two notches, and leave the background color as-is instead.
Contributor
Author
|
This matches the work-around I implemented for mesa3d.org. |
Contributor
Author
|
Worth to note, this increases the contrast ratio from 8.22 to 13.1. |
Contributor
Author
It's not white, it's just a bit closer to white. FWIW, the contrast between the body-text and the headings are now more similar to what we do for light mode, which seems like a good thing to me: |
mdo
approved these changes
Jun 25, 2023
Member
mdo
left a comment
There was a problem hiding this comment.
This feels like a great first start to me, thanks!
3 tasks
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced Sep 18, 2024
This was referenced Sep 24, 2024
This was referenced Sep 28, 2024
This was referenced Sep 30, 2024
This was referenced Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
This increases the default brightness for the body text-color in dark mode, which inceases readability a bit.
It was also suggested to darken the background a bit, but we unfortunately don't have a darker gray in our color palette. So for now, let's increase the text-color by two notches, and leave the background color as-is instead.
Motivation & Context
See issue #38525
Type of changes
Checklist
npm run lint)(not really sure any of the above applies here)
Live previews
Related issues
#38525