Added lint as action#30
Merged
mhutchinson merged 2 commits intotransparency-dev:mainfrom May 27, 2022
Merged
Conversation
This gives cleaner integration compared to digging around in cloudbuild output. We still may need to do GCB integration to perform further checks though. https://github.com/golangci/golangci-lint-action
pav-kv
approved these changes
May 27, 2022
.github/workflows/golangci-lint.yml
Outdated
Comment on lines
+4
to
+7
| tags: | ||
| - v* | ||
| branches: | ||
| - main |
Contributor
There was a problem hiding this comment.
I this a required section? Can this be just "any" for short?
Contributor
Author
There was a problem hiding this comment.
What's the benefit?
Contributor
There was a problem hiding this comment.
Shortness, and fewer assumptions about how branches are named.
Contributor
Author
There was a problem hiding this comment.
I've removed all the filters. Any push to any branch, off fires the linter.
I don't see the benefit, but we can always change it.
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 7 7
Lines 497 497
=======================================
Hits 442 442
Misses 50 50
Partials 5 5 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives cleaner integration compared to digging around in cloudbuild output. We still may need to do GCB integration to perform further checks though. https://github.com/golangci/golangci-lint-action