chore(ci): upgrade go to v1.23 and linter

mloiseleur · web-flow · commit 4c339e1ec673 · 2025-01-21T10:02:04.000+01:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     env:
       GO_VERSION: stable
-      GOLANGCI_LINT_VERSION: v1.58.0
+      GOLANGCI_LINT_VERSION: v1.63.4
       CGO_ENABLED: 0
 
     steps:
diff --git a/.golangci.yml b/.golangci.yml
@@ -52,30 +52,18 @@ linters-settings:
 linters:
   enable-all: true
   disable:
-    - deadcode # deprecated
-    - exhaustivestruct # deprecated
-    - golint # deprecated
-    - ifshort # deprecated
-    - interfacer # deprecated
-    - maligned # deprecated
-    - nosnakecase # deprecated
-    - scopelint # deprecated
-    - scopelint # deprecated
-    - structcheck # deprecated
-    - varcheck # deprecated
-    - execinquery # not relevant (SQL)
     - rowserrcheck # not relevant (SQL)
     - sqlclosecheck # not relevant (SQL)
     - cyclop # duplicate of gocyclo
     - dupl
     - exhaustive
     - exhaustruct
+    - exportloopref
     - forbidigo
     - gochecknoglobals
     - gochecknoinits
     - err113
     - mnd
-    - gomnd
     - gosec
     - lll
     - nilnil
diff --git a/app.go b/app.go
@@ -159,7 +159,7 @@ func echoHandler(w http.ResponseWriter, r *http.Request) {
 
 func printBinary(s []byte) {
 	fmt.Printf("Received b:")
-	for n := 0; n < len(s); n++ {
+	for n := range s {
 		fmt.Printf("%d,", s[n])
 	}
 	fmt.Printf("\n")
diff --git a/content_test.go b/content_test.go
@@ -19,7 +19,6 @@ func Test_contentReader_Read(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -56,7 +55,6 @@ func Test_contentReader_ReadSeek(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
 
diff --git a/go.mod b/go.mod
@@ -1,7 +1,5 @@
 module github.com/traefik/whoami
 
-go 1.21
+go 1.23
 
-require github.com/gorilla/websocket v1.5.1
-
-require golang.org/x/net v0.25.0 // indirect
+require github.com/gorilla/websocket v1.5.3
diff --git a/go.sum b/go.sum
@@ -1,4 +1,2 @@
-github.com/gorilla/websocket v1.5.1 h1:gmztn0JnHVt9JZquRuzLw3g4wouNVzKL15iLr/zn/QY=
-github.com/gorilla/websocket v1.5.1/go.mod h1:x3kM2JMyaluk02fnUJpQuwD2dCS5NDG2ZHL0uE0tcaY=
-golang.org/x/net v0.25.0 h1:d/OCCoBEUq33pjydKrGQhw7IlUPI2Oylr+8qLx49kac=
-golang.org/x/net v0.25.0/go.mod h1:JkAGAh7GEvH74S6FOH42FLoXpXbE/aqXSrIQjXgsiwM=
+github.com/gorilla/websocket v1.5.3 h1:saDtZ6Pbx/0u+bgYQ3q96pZgCzfhKXGPqt7kZ72aNNg=
+github.com/gorilla/websocket v1.5.3/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ func echoHandler(w http.ResponseWriter, r *http.Request) {`
`159`	`159`
`160`	`160`	`func printBinary(s []byte) {`
`161`	`161`	`fmt.Printf("Received b:")`
`162`		`- for n := 0; n < len(s); n++ {`
	`162`	`+ for n := range s {`
`163`	`163`	`fmt.Printf("%d,", s[n])`
`164`	`164`	`}`
`165`	`165`	`fmt.Printf("\n")`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ func Test_contentReader_Read(t *testing.T) {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`for _, test := range tests {`
`22`		`- test := test`
`23`	`22`	`t.Run(test.name, func(t *testing.T) {`
`24`	`23`	`t.Parallel()`
`25`	`24`
`@@ -56,7 +55,6 @@ func Test_contentReader_ReadSeek(t *testing.T) {`
`56`	`55`	`}`
`57`	`56`
`58`	`57`	`for _, test := range tests {`
`59`		`- test := test`
`60`	`58`	`t.Run(test.name, func(t *testing.T) {`
`61`	`59`	`t.Parallel()`
`62`	`60`