Skip to content

🐛 fix(config): fix handling of env_list in nested contexts#3905

Merged
gaborbernat merged 2 commits intotox-dev:mainfrom
Daverball:bugfix/config/toml_nested_env_list
Mar 27, 2026
Merged

🐛 fix(config): fix handling of env_list in nested contexts#3905
gaborbernat merged 2 commits intotox-dev:mainfrom
Daverball:bugfix/config/toml_nested_env_list

Conversation

@Daverball
Copy link
Copy Markdown
Contributor

@Daverball Daverball commented Mar 26, 2026

Plugins like tox-gh that introduce nested config entries containing an env_list did not properly support TOML-specific features, due to a bug in the validation logic.

As a result using a generated env_list was only possible using the INI format.

Fixes #3898

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation (no docs changes necessary I think?)

Plugins like tox-gh that introduce nested config entries containing an
env_list did not properly support TOML-specific features, due to a bug
in the validation logic.

As a result using a generated env_list was only possible using the INI
format.

Fixes tox-dev#3898
@Daverball Daverball requested a review from rahuldevikar as a code owner March 26, 2026 07:48
@gaborbernat gaborbernat merged commit 8c9c199 into tox-dev:main Mar 27, 2026
27 checks passed
@Daverball Daverball deleted the bugfix/config/toml_nested_env_list branch March 27, 2026 12:34
gaborbernat pushed a commit to gaborbernat/tox that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tox config parser doesn't properly validate nested complex types like EnvList

2 participants