🐛 fix(type): resolve ty 0.0.17 compatibility#3807
Merged
gaborbernat merged 1 commit intomainfrom Feb 21, 2026
Merged
Conversation
ty 0.0.17 introduced `redundant-final-classvar` and `call-top-callable` diagnostics. The `Final[ClassVar[...]]` combination was redundant, and `callable()` on `Callable[[], T] | T` can't be statically narrowed when `T` is unconstrained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ty 0.0.17 introduced new diagnostics that cause CI failures. The
redundant-final-classvarwarning flagsFinal[ClassVar[...]]indocs/tox_conf.pysinceFinalalready implies class-level scope, makingClassVarredundant. Thecall-top-callableerrors insrc/tox/config/of_type.pyarise becausecallable()cannot statically narrowCallable[[], T] | TwhenTis an unconstrained type variable — the value could itself be callable, so ty can't determine the call signature.Removed the redundant
Finalwrapper and addedty: ignore[call-top-callable]suppressions for the twocallable()guards, which are a valid runtime pattern that ty cannot verify statically.