🐛 fix(test): resolve Windows CI flake in provision integration tests#3732
Merged
gaborbernat merged 1 commit intotox-dev:mainfrom Feb 17, 2026
Merged
Conversation
527543b to
1d1d8ec
Compare
The test_provision_install_pkg_pep517 consistently exceeds the global 30s pytest-timeout on Windows CI (takes ~32s), causing intermittent failures. Increase its timeout to 120s. Re-enable test_provision_requires_ok on Windows (was skipped due to suspected deadlock, but the actual issue was just timeout).
1d1d8ec to
2ecdefe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows CI job
test 3.12 on windows-2025fails intermittently ontest_provision_install_pkg_pep517. Investigation showed the test consistently takes ~32s on Windows due to provisioned subprocess pip installs, which exceeds the global 30spytest-timeout. The "deadlock" stack trace is actuallypytest-timeoutdumping threads before killing the test. 🔍The fix raises the timeout to 120s for both provision integration tests that spawn real subprocesses. This also re-enables
test_provision_requires_okon Windows, which was skipped under the assumption it deadlocked — the actual cause was the same 30s timeout being too tight for these heavier integration tests.Validated with 20/20 passes on
windows-2025CI runners.