Skip to content

🐛 fix(ci): add completion extras to type checker environments#3728

Merged
gaborbernat merged 1 commit intotox-dev:mainfrom
gaborbernat:fix-type-argcomplete
Feb 17, 2026
Merged

🐛 fix(ci): add completion extras to type checker environments#3728
gaborbernat merged 1 commit intotox-dev:mainfrom
gaborbernat:fix-type-argcomplete

Conversation

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented Feb 17, 2026

The type and type-min CI environments fail because ty cannot resolve the argcomplete module imported in src/tox/config/cli/parse.py and tests/config/cli/test_argcomplete.py. While env_run_base declares extras = ["completion"], the type environments weren't picking it up reliably, causing error[unresolved-import] on fresh CI runs.

🔧 The fix explicitly sets extras = ["completion"] on both env.type and env.type-min in tox.toml, reusing the existing optional-dependencies.completion that already defines argcomplete>=3.6.3 rather than duplicating the dependency.

@gaborbernat gaborbernat changed the title Add argcomplete to type checker dependency groups 🐛 fix(ci): add argcomplete to type checker dependency groups Feb 17, 2026
@gaborbernat gaborbernat changed the title 🐛 fix(ci): add argcomplete to type checker dependency groups 🐛 fix(ci): add completion extras to type checker environments Feb 17, 2026
@gaborbernat gaborbernat merged commit 0d3f901 into tox-dev:main Feb 17, 2026
28 checks passed
@gaborbernat gaborbernat deleted the fix-type-argcomplete branch February 18, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant