Allow braced range syntax in internal sections of tox.ini file#3631
Merged
gaborbernat merged 5 commits intotox-dev:mainfrom Oct 24, 2025
Merged
Allow braced range syntax in internal sections of tox.ini file#3631gaborbernat merged 5 commits intotox-dev:mainfrom
gaborbernat merged 5 commits intotox-dev:mainfrom
Conversation
Contributor
Author
|
Two doubts, open to input:
|
gaborbernat
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3571
Partially fixes #3614 -> This PR covers the complaint about using dash syntax in
deps. It does not address the complaint about nested braces syntax.This PR refactors how
expand_rangesis used when loading .ini config files. Instead of callingexpand_rangesdirectly when expanding envs or section names, we expand it once we start finding the factor groups, infind_factor_groups()function.This means that ranges in sections like
depsandsetenvwill also be expanded. Before, only env_list and section names were expanded. Considered as bugfix due to the original issue classification, but could also arguably be considered a small feature.The approach was done in this way so that we don't have to "remember" to call expand_ranges everywhere that we use the brace syntax {}. Instead, whenever we are expanding factors, transparently the ranges will be expanded.
tox -e fix)docs/changelogfolder