fix skip with package = wheel by lczyk · Pull Request #3269 · tox-dev/tox

lczyk · 2024-04-21T22:25:21Z

Fix for #3153

ran the linter to address style issues (tox -e fix)
wrote descriptive pull request text
ensured there are test(s) validating the fix
added news fragment in docs/changelog folder
[n/a] updated/extended the documentation

gaborbernat

Test please

lczyk · 2024-04-26T17:30:28Z

Ok, the only failing test is test_depends.py due to missing output lines:

Any hint as to where am I supposed to return that status? (sorry, a bit lost in the code) so far i'm looking at report called from execute, both in common.py

lczyk · 2024-04-26T17:32:18Z

For reference, here is the stack from the failing case:

Traceback (most recent call last):
  File ".../tox/src/tox/run.py", line 20, in run
    result = main(sys.argv[1:] if args is None else args)
  File ".../tox/src/tox/run.py", line 46, in main
    return handler(state)
  File ".../tox/src/tox/session/cmd/legacy.py", line 115, in legacy
    return run_sequential(state)
  File ".../tox/src/tox/session/cmd/run/sequential.py", line 25, in run_sequential
    return execute(state, max_workers=1, has_spinner=False, live=True)
  File ".../tox/src/tox/session/cmd/run/common.py", line 170, in execute
    cast(RunToxEnv, state.envs[name]).mark_active()
  File ".../tox/src/tox/tox_env/runner.py", line 211, in mark_active
    for pkg_env in self.package_envs:
  File ".../tox/src/tox/tox_env/runner.py", line 208, in package_envs
    yield from self.package_env.child_pkg_envs(self.conf)
  File ".../tox/src/tox/tox_env/python/package.py", line 124, in child_pkg_envs
    conf = run_conf["wheel_build_env"]
  File ".../tox/src/tox/config/sets.py", line 116, in __getitem__
    return self.load(item)
  File ".../tox/src/tox/config/sets.py", line 127, in load
    return config_definition.__call__(self._conf, self.loaders, ConfigLoadArgs(chain, self.name, self.env_name))  # noqa: PLC2801
  File ".../tox/src/tox/config/of_type.py", line 111, in __call__
    value = self.default(conf, args.env_name) if callable(self.default) else self.default
  File ".../tox/src/tox/tox_env/python/package.py", line 93, in default_wheel_tag
    run_py = cast(Python, run_env).base_python
  File ".../tox/src/tox/tox_env/python/api.py", line 260, in base_python
    raise Skip(msg)
tox.tox_env.errors.Skip: could not find python interpreter with spec(s): py310

for more information, see https://pre-commit.ci

lczyk · 2024-04-27T12:27:28Z

ok, compared and matched the behaviour to package = sdist. After stepping through the code it looks like it was nothing to do with the report, which looks correct when running the normal tox command with the patch on a test repo.

lczyk · 2024-04-27T12:28:19Z

Also patched _make_tox_wheel to allow pytest --run-integration run with a dev patch version, to allow all tests to pass locally.

gaborbernat · 2024-04-27T14:32:20Z

Thank you for your contribution.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [tox](https://togithub.com/tox-dev/tox) ([changelog](https://tox.wiki/en/latest/changelog.html)) | `4.15.0` -> `4.15.1` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/tox/4.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/tox/4.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/tox/4.15.0/4.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/tox/4.15.0/4.15.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/tox (tox)</summary> ### [`v4.15.1`](https://togithub.com/tox-dev/tox/releases/tag/4.15.1) [Compare Source](https://togithub.com/tox-dev/tox/compare/4.15.0...4.15.1)  #### What's Changed - fix skip with package = wheel by [@MarcinKonowalczyk](https://togithub.com/MarcinKonowalczyk) in [https://github.com/tox-dev/tox/pull/3269](https://togithub.com/tox-dev/tox/pull/3269) - Fixed typo in user guide. by [@carltongibson](https://togithub.com/carltongibson) in [https://github.com/tox-dev/tox/pull/3277](https://togithub.com/tox-dev/tox/pull/3277) - Fix broad build privileges @ GHA release workflow by [@webknjaz](https://togithub.com/webknjaz) in [https://github.com/tox-dev/tox/pull/3281](https://togithub.com/tox-dev/tox/pull/3281) - Allow `ConfigSet.add_config` to receive parameterized generics for `of_type`. by [@ssbarnea](https://togithub.com/ssbarnea) in [https://github.com/tox-dev/tox/pull/3288](https://togithub.com/tox-dev/tox/pull/3288) - Fix section substitution with setenv by [@JJLLWW](https://togithub.com/JJLLWW) in [https://github.com/tox-dev/tox/pull/3289](https://togithub.com/tox-dev/tox/pull/3289) #### New Contributors - [@MarcinKonowalczyk](https://togithub.com/MarcinKonowalczyk) made their first contribution in [https://github.com/tox-dev/tox/pull/3269](https://togithub.com/tox-dev/tox/pull/3269) - [@carltongibson](https://togithub.com/carltongibson) made their first contribution in [https://github.com/tox-dev/tox/pull/3277](https://togithub.com/tox-dev/tox/pull/3277) - [@JJLLWW](https://togithub.com/JJLLWW) made their first contribution in [https://github.com/tox-dev/tox/pull/3289](https://togithub.com/tox-dev/tox/pull/3289) **Full Changelog**: tox-dev/tox@4.15.0...4.15.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/naa0yama/FFmpeg-video-quality-evaluations).

lczyk requested a review from gaborbernat as a code owner April 21, 2024 22:25

psf-chronographer bot added the bot:chronographer:provided label Apr 21, 2024

gaborbernat requested changes Apr 21, 2024

View reviewed changes

gaborbernat marked this pull request as draft April 23, 2024 16:43

lczyk added 2 commits April 26, 2024 18:02

patch pytest --run-integration to run with dev versions

dae5483

fix skip with package = wheel

bfead83

lczyk and others added 5 commits April 27, 2024 12:50

added sdist test

b2b2ff4

adjust wheel tests

18dbc9a

add docs chanelog news fragment

100bbe4

[pre-commit.ci] auto fixes from pre-commit.com hooks

810c1df

for more information, see https://pre-commit.ci

fix backticks

63acdef

lczyk force-pushed the patch branch from d514135 to 63acdef Compare April 27, 2024 11:54

pre-commit-ci bot and others added 2 commits April 27, 2024 11:55

[pre-commit.ci] auto fixes from pre-commit.com hooks

9ffd88e

for more information, see https://pre-commit.ci

isinstance(_patch_version, str)

be21104

lczyk marked this pull request as ready for review April 27, 2024 12:34

lczyk requested a review from gaborbernat April 27, 2024 12:34

Merge branch 'main' into patch

4158e80

gaborbernat approved these changes Apr 27, 2024

View reviewed changes

gaborbernat merged commit 3db9822 into tox-dev:main Apr 27, 2024

lczyk mentioned this pull request Apr 28, 2024

skip_missing_interpreters is broken (again) #3153

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix skip with package = wheel#3269

fix skip with package = wheel#3269
gaborbernat merged 10 commits intotox-dev:mainfrom
lczyk:patch

lczyk commented Apr 21, 2024 •

edited

Loading

Uh oh!

gaborbernat left a comment

Uh oh!

lczyk commented Apr 26, 2024

Uh oh!

lczyk commented Apr 26, 2024

Uh oh!

lczyk commented Apr 27, 2024

Uh oh!

lczyk commented Apr 27, 2024 •

edited

Loading

Uh oh!

gaborbernat commented Apr 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lczyk commented Apr 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaborbernat left a comment

Choose a reason for hiding this comment

Uh oh!

lczyk commented Apr 26, 2024

Uh oh!

lczyk commented Apr 26, 2024

Uh oh!

lczyk commented Apr 27, 2024

Uh oh!

lczyk commented Apr 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gaborbernat commented Apr 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lczyk commented Apr 21, 2024 •

edited

Loading

lczyk commented Apr 27, 2024 •

edited

Loading