Skip to content

Support multiple override appends#3261

Merged
gaborbernat merged 1 commit intotox-dev:mainfrom
amitschang:multiple-override-append
Apr 3, 2024
Merged

Support multiple override appends#3261
gaborbernat merged 1 commit intotox-dev:mainfrom
amitschang:multiple-override-append

Conversation

@amitschang
Copy link
Copy Markdown
Contributor

@amitschang amitschang commented Apr 3, 2024

Currently only the last override supplied is considered, in conflict with now supported append overrides ("+="). This now enables appending multiple times via the command line.

The docs are also misleading for dependencies, where seems to imply a comma-separated list of dependencies can be given in the override, but there is no handling of this (and there probably shouldn't be, since , is a possible character in version spec).

With this change, something like

tox -e env -x testenv.deps+=debugpy -x testenv.deps+=pytest

would be possible.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@amitschang amitschang requested a review from gaborbernat as a code owner April 3, 2024 17:58
Copy link
Copy Markdown
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please

Currently only the last override supplied is considered, in conflict with now
supported append overrides ("+="). This now enables appending multiple times via
the command line.
@amitschang
Copy link
Copy Markdown
Contributor Author

@gaborbernat, done, thanks!

@amitschang amitschang requested a review from gaborbernat April 3, 2024 20:30
@gaborbernat gaborbernat enabled auto-merge (squash) April 3, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants