🔧 fix(ci): restore git credentials and remove workaround#335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zizmor security tool added
persist-credentials: falseto the checkout step, requiring agit remote set-urlworkaround to restore push capabilities. This workaround exposes the token in process listings and shell history, which is worse for security than the original credential persistence.Removing both
persist-credentials: falseand the workaround simplifies the workflow while maintaining security. ✨ Theartipackedwarning is suppressed with an inline ignore because it's a false positive—this job never uploads artifacts that could leak credentials. Using the default credential persistence is the intended design for jobs that need to push.This change only affects the mirror workflow. The approach aligns with GitHub's recommended practice for jobs requiring repository write access.