Fix test failures on BSD for runtime directory defaults#451
Merged
gaborbernat merged 3 commits intotox-dev:mainfrom Feb 17, 2026
Merged
Fix test failures on BSD for runtime directory defaults#451gaborbernat merged 3 commits intotox-dev:mainfrom
gaborbernat merged 3 commits intotox-dev:mainfrom
Conversation
Use platform-aware defaults for site_runtime_dir and user_runtime_dir in test expectations: /var/run on BSD systems, /run on Linux. This matches the production code behavior in unix.py. Fixes tox-dev#449
for more information, see https://pre-commit.ci
Member
|
Please mark it ready once CI passes. |
…heck The long line was being reformatted by ruff format, which dropped the noqa comment. Pre-split with noqa on the os.path.join line. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gaborbernat
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three test failures on NetBSD (and FreeBSD/OpenBSD) where
site_runtime_diranduser_runtime_dirtests hardcode/runas the expected default, but BSD systems use/var/run.The production code in
unix.pyalready handles this correctly. This change makes the test expectations match.Fixes #449
Changes
_func_to_path:site_runtime_dirdefault is now/var/runon BSD,/runotherwise_SITE_REDIRECT_CASES:user_runtime_direxpected path uses/var/runon BSD,/runotherwiseTest plan
/run)/var/run, matching production behavior