Fix TypeError: _CountedFileLock.__init__() got an unexpected keyword argument 'timeout'#345
Merged
gaborbernat merged 4 commits intotox-dev:mainfrom Jun 19, 2024
Merged
Conversation
…argument 'timeout'
TypeError: _CountedFileLock.__init__() got an unexpected keyword argument 'timeout'
…ing library stubs or py.typed marker [import-untyped]
gaborbernat
approved these changes
Jun 19, 2024
Merged
Merged
hmaarrfk
added a commit
to ramonaoptics/python-multiuserfilelock
that referenced
this pull request
Dec 31, 2024
A breaking change in tox-dev/filelock#345 cause the locks to hang
Contributor
|
Is this kind of behavior actually desirable? It causes parameter to just "silently get dropped" and users may expect them to have an effect.... |
Contributor
|
I guess I think you should decide on the common signature you want to support. Does it include **kwargs?? Anyway, we hit this because we subclassed you guys and our signature was: and the In either case, we are just going to stop subclassing, but signature rewriting should really not be used for this kind of convenience stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Fixed an issue with the
BaseFileLocksubclass when the__init__method signature changesIssues
Related PRs