Skip to content

Hotfix: Restore __init__ method; more robust initialization for singleton locks#338

Merged
gaborbernat merged 14 commits intotox-dev:mainfrom
ethanbb:init-signature-fix
Jun 12, 2024
Merged

Hotfix: Restore __init__ method; more robust initialization for singleton locks#338
gaborbernat merged 14 commits intotox-dev:mainfrom
ethanbb:init-signature-fix

Conversation

@ethanbb
Copy link
Contributor

@ethanbb ethanbb commented Jun 12, 2024

Fixes issue with subclassing brought up in pypa/virtualenv#2735 (discussed in #334)

tamird
tamird reviewed Jun 12, 2024
View reviewed changes
@ethanbb
Copy link
Contributor Author

ethanbb commented Jun 12, 2024

Will add a test for this as well.

kwist-sgr
kwist-sgr reviewed Jun 12, 2024
View reviewed changes
@ethanbb
Copy link
Contributor Author

ethanbb commented Jun 12, 2024

Sorry for this mess. I understand if you want to take longer to review this time; did not realize so much infrastructure relies on this package.

@gaborbernat
Copy link
Member

gaborbernat commented Jun 12, 2024

Sorry for this mess. I understand if you want to take longer to review this time; did not realize so much infrastructure relies on this package.

No worries All good.

tamird
tamird approved these changes Jun 12, 2024
View reviewed changes
Copy link

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@ethanbb ethanbb changed the title Hotfix: Restore __init__ method and use different strategy to bypass initialization Hotfix: Restore __init__ method; more robust initialization for singleton locks Jun 12, 2024
gaborbernat
gaborbernat requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the error message for each parameter differing 👍

stasfilin
stasfilin reviewed Jun 12, 2024
View reviewed changes
@ethanbb
Copy link
Contributor Author

ethanbb commented Jun 12, 2024

I had this test failure on test_singleton_locks_are_deleted_when_no_external_references_exist when testing locally as well and couldn't figure out what was wrong. Anyone have an idea?

gaborbernat
gaborbernat previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanbb
Copy link
Contributor Author

ethanbb commented Jun 12, 2024

I had this test failure on test_singleton_locks_are_deleted_when_no_external_references_exist when testing locally as well and couldn't figure out what was wrong. Anyone have an idea?

Never mind, got it

gaborbernat
gaborbernat approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat enabled auto-merge (squash) June 12, 2024 22:52
@gaborbernat gaborbernat merged commit 3d7b1a6 into tox-dev:main Jun 12, 2024
@ethanbb ethanbb deleted the init-signature-fix branch June 12, 2024 22:55
@kwist-sgr kwist-sgr mentioned this pull request Jun 17, 2024
Merged
@gaborbernat gaborbernat mentioned this pull request Jun 19, 2024
Merged
@gaborbernat gaborbernat mentioned this pull request Sep 7, 2024
Merged
@gaborbernat gaborbernat mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

+3 more reviewers

@tamird tamird tamird approved these changes

@kwist-sgr kwist-sgr kwist-sgr left review comments

@stasfilin stasfilin stasfilin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ethanbb @gaborbernat @tamird @kwist-sgr @stasfilin