Skip to content

ci: fix flaky encoding test, add nightly stress test job#670

Merged
jlizen merged 2 commits into
tower-rs:mainfrom
jlizen:fix/encoding_test_flakiness
May 6, 2026
Merged

ci: fix flaky encoding test, add nightly stress test job#670
jlizen merged 2 commits into
tower-rs:mainfrom
jlizen:fix/encoding_test_flakiness

Conversation

@jlizen

@jlizen jlizen commented May 6, 2026

Copy link
Copy Markdown
Member

Fixes #668

Summary

The flaky assertion compared brotli and deflate output sizes on a 5.5 KB input where the ratio is only ~2.5% under the threshold, so streaming chunk timing occasionally pushed it over. Replaced the size-ratio proxy with a direct round-trip decode check using flate2 and brotli, which verifies the actual invariant: that the configured codec was used.

Also added a daily stress-test workflow, with workflow_dispatch for manual runs and a scheduled daily run, so this class of flake surfaces before hitting PR authors.

Testing

Ran cargo nextest run --stress-duration against the target test and the full suite; no failures.

@jlizen jlizen enabled auto-merge (squash) May 6, 2026 19:36
@jlizen jlizen merged commit 309555a into tower-rs:main May 6, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci] flakey test: compression::layer::tests::accept_encoding_configuration_works

2 participants