Fix serve_dir method not allowed handling when no fallback is configured#587
Merged
jlizen merged 1 commit intoMay 6, 2026
Merged
Conversation
Fixes a bug in `ServeDir` where non-GET/HEAD requests were incorrectly processed when `call_fallback_on_method_not_allowed` is enabled but no fallback service is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
ServeDirwhere non-GET/HEAD requests were incorrectly processed whencall_fallback_on_method_not_allowedis enabled but no fallback service is provided.Problem
When configured with
call_fallback_on_method_not_allowed(true)but no fallback service, non-GET/HEAD requests would proceed through normal file serving logic instead of returning405 Method Not Allowed.