fix: update node filtering logic to exclude TABLE and ARRAY_OF_TABLE kinds#1528
Merged
fix: update node filtering logic to exclude TABLE and ARRAY_OF_TABLE kinds#1528
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where comments between key-value pairs and array-of-tables ([[...]]) sections were being incorrectly removed during formatting. The issue occurred because the node filtering logic in key_values_end_dangling_comments() only checked for TABLE nodes but not ARRAY_OF_TABLE nodes.
Changes:
- Updated the filtering logic in
Root::key_values_end_dangling_comments()to exclude bothTABLEandARRAY_OF_TABLEsyntax nodes - Added a regression test (
test_issue_1527_toml) that verifies comments before array-of-tables are preserved during formatting
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/tombi-ast/src/impls/root.rs |
Fixed the node filtering logic to exclude both TABLE and ARRAY_OF_TABLE kinds when collecting end dangling comments |
crates/tombi-formatter/src/lib.rs |
Added regression test for issue #1527 to verify comments before array-of-tables are preserved |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #1527