metrics: add worker thread id#6695
Merged
Darksonn merged 10 commits intotokio-rs:masterfrom Jul 23, 2024
Merged
Conversation
This allows querying the thread id of each worker thread. Additional information, such as native thread id, can be collected using runtime::Builder::on_thread_start() and correlated using the thread id.
Darksonn
reviewed
Jul 21, 2024
Darksonn
approved these changes
Jul 23, 2024
Member
Darksonn
left a comment
There was a problem hiding this comment.
Thanks. This looks good to me.
Comment on lines
+136
to
+138
| /// If additional information about the thread, such as its native id, are | ||
| /// required, those can be collected in [`on_thread_start`] and correlated | ||
| /// using the thread id. |
Member
There was a problem hiding this comment.
This is enough for your purposes?
Contributor
Author
There was a problem hiding this comment.
Yes, for now we just want to send SIGABRT to the hanging thread and for that we collect the pthread_t id of each worker thread in on_thread_start.
This was referenced Jul 23, 2024
Add worker id to
on_thread_park() and on_thread_unpark() callbacks (for stuck worker watchdog)
#6353
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows querying the thread id of each worker thread.
Additional information, such as native thread id, can be collected using
runtime::Builder::on_thread_start()and correlated using the thread id.Motivation
See #6353 and discussion in #6370.
Solution
Provides thread ids of workers, so that a stuck worker can be correlated to a thread.