Skip to content

Update nix and mio-aio dev-dependencies to the latest#6552

Merged
Darksonn merged 1 commit intotokio-rs:masterfrom
asomers:nix_0.28
May 25, 2024
Merged

Update nix and mio-aio dev-dependencies to the latest#6552
Darksonn merged 1 commit intotokio-rs:masterfrom
asomers:nix_0.28

Conversation

@asomers
Copy link
Copy Markdown
Contributor

@asomers asomers commented May 12, 2024

Motivation

Use the latest version of Nix as requested by @fkm3 .

Solution

Update Nix to the latest version. This version uses I/O Safety for most functions. It also necessitates updating the mio-aio dev dependency.

This PR supersedes #6474 , but it depends on unreleased nix and mio-aio crates.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-io Module: tokio/io M-net Module: tokio/net labels May 12, 2024
Copy link
Copy Markdown
Member

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.

Comment thread tokio/tests/io_poll_aio.rs Outdated
@fkm3
Copy link
Copy Markdown
Contributor

fkm3 commented May 13, 2024

Thanks!

nix 0.29.0 and mio-aio 0.9.0 use I/O Safety.
@asomers asomers marked this pull request as ready for review May 24, 2024 23:57
@asomers asomers requested a review from Darksonn May 24, 2024 23:57
Copy link
Copy Markdown
Member

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 12920ce into tokio-rs:master May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tokio Area: The main tokio crate M-io Module: tokio/io M-net Module: tokio/net

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants