macros: render more comprehensible documentation for select!#6468
Merged
Darksonn merged 2 commits intotokio-rs:masterfrom Apr 6, 2024
Merged
macros: render more comprehensible documentation for select!#6468Darksonn merged 2 commits intotokio-rs:masterfrom
select!#6468Darksonn merged 2 commits intotokio-rs:masterfrom
Conversation
Member
|
Looks sensible. Thanks! Does this hide docs from ide tooltips? |
Darksonn
reviewed
Apr 6, 2024
Contributor
Author
Yes, seems it does. Good call. I found a way to fix it. |
Darksonn
approved these changes
Apr 6, 2024
Member
Darksonn
left a comment
There was a problem hiding this comment.
Thanks for the doc improvement! Looks good to me.
The extra indentation is unfortunate, but oh well.
auto-merge was automatically disabled
April 6, 2024 22:45
Head branch was pushed to by a user without write access
Contributor
Author
|
In fact the extra indentation wrecked the docs, too.
I pushed a different approach without indentation, that rustfmt is still okay with. |
Member
|
Good catch. |
This was referenced Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution