Skip to content

io: implement AsyncBufRead for Join#6449

Merged
Darksonn merged 1 commit intotokio-rs:masterfrom
bharath-123:impl-asyncbufread-for-join
Apr 2, 2024
Merged

io: implement AsyncBufRead for Join#6449
Darksonn merged 1 commit intotokio-rs:masterfrom
bharath-123:impl-asyncbufread-for-join

Conversation

@bharath-123
Copy link
Copy Markdown
Contributor

@bharath-123 bharath-123 commented Apr 1, 2024

Motivation

The Join struct implements the AsyncRead and AsyncWrite interface. This PR implements the AsyncReadBuf interface.
Fixes #6446

Solution

We implement the AsyncReadBuf interface for the Join, if the Reader also implements the AsyncReadBuf interface.

@mox692 mox692 added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Apr 2, 2024
Copy link
Copy Markdown
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@Darksonn Darksonn merged commit e9ae5d4 into tokio-rs:master Apr 2, 2024
@bharath-123 bharath-123 deleted the impl-asyncbufread-for-join branch April 2, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tokio Area: The main tokio crate M-io Module: tokio/io

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tokio::io::Join should implement AsyncBufRead

3 participants