Merged
Conversation
Make it possible to add directives as commandline parameter. Alternatively to `//msgp:tag json` directives can also be specified using the `-d` flag. Example: `msgp -d "tag json"`. Multiple flags can be added. Directives in files take precedence over commandline. Bonus: Print info on all directives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to add directives as commandline parameter.
Alternatively to
//msgp:tag jsondirectives can also be specified using the-dflag. Example:msgp -d "tag json". Multiple flags can be added.Directives in files take precedence over commandline.
This is mainly to be able to compact directives into a single
go generateline. We have something like 4-5 directivesclearomitted,timezone utc, etc in some of our files, so this would make this neater.Bonus: Print info on all directives.