Encode \b and \f in JSON string as themselves#348
Merged
tidwall merged 2 commits intotidwall:masterfrom Feb 15, 2024
Merged
Conversation
Owner
|
Merged. I had to modify your test to exclude older Go versions ... in case 1.21 users want to pass the tests. |
Owner
|
and thanks for the PR :) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a test failure by adapting
AppendJSONStringto follow the new behavior of encoding/json in Go 1.22. The corresponding test case is appended by a check of the\band\fcharacters.Since Go 1.22 the encoding/json library encodes the characters
\band\fas themselves. Before 1.22 they were encoded as\u0008and\u000c. The new behavior failsTestJSONString:Go 1.22 release notes: https://tip.golang.org/doc/go1.22#minor_library_changes