Skip to content

bug: email templates + branding permissions#2237

Merged
adelowo merged 4 commits intomainfrom
bug-email-templates
Mar 31, 2026
Merged

bug: email templates + branding permissions#2237
adelowo merged 4 commits intomainfrom
bug-email-templates

Conversation

@golanglemonade
Copy link
Copy Markdown
Member

@golanglemonade golanglemonade commented Mar 31, 2026 •
edited
Loading

  • fixes a bug with permissions to the edges for email branding + templates
  • removes unique constraint for email_branding to template - allowing the same branding to be used across multiple templates
  • fixes bug with template context, it should be required so there is no empty enum but it wasn't previously required
  • adds unit tests for both email branding and templates

@golanglemonade
fix email templates + branding permissions
5520884 
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade
allow same branding on many templates, add tests
6ce780f 
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade
db:resethash
3eb0298 
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@golanglemonade golanglemonade requested a review from a team as a code owner March 31, 2026 06:00
@golanglemonade
fix linter
838c062 
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 31, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@adelowo adelowo merged commit a4177e2 into main Mar 31, 2026
20 of 21 checks passed
@adelowo adelowo deleted the bug-email-templates branch March 31, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matoszz matoszz matoszz approved these changes

@adelowo adelowo Awaiting requested review from adelowo adelowo is a code owner automatically assigned from theopenlane/blacksmiths

@theopenlane-bender theopenlane-bender Awaiting requested review from theopenlane-bender theopenlane-bender is a code owner automatically assigned from theopenlane/blacksmiths

Assignees

No one assigned

Labels

authorization bug Something isn't working dbschema graphapi graphqlschema httpserve migrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@golanglemonade @matoszz @adelowo