chore: add prettier and run format#140
Merged
thecodrr merged 2 commits intothecodrr:masterfrom Apr 19, 2025
Merged
Conversation
Adds prettier to the project and applies the formatting changes.
Owner
That's a good idea. The other extra trailing commas look absurd. |
Contributor
Author
|
that has reduced the diff massively 👍 can you take another look? |
benmccann
approved these changes
Apr 18, 2025
Comment on lines
+161
to
+164
| globWithOptions( | ||
| patterns: string[], | ||
| ...options: GlobParams<TGlobFunction> | ||
| ): Builder<TReturnType, TGlobFunction>; |
Contributor
There was a problem hiding this comment.
this would probably be easier to read with a new line between the method declarations
Suggested change
| globWithOptions( | |
| patterns: string[], | |
| ...options: GlobParams<TGlobFunction> | |
| ): Builder<TReturnType, TGlobFunction>; | |
| globWithOptions( | |
| patterns: string[], | |
| ...options: GlobParams<TGlobFunction> | |
| ): Builder<TReturnType, TGlobFunction>; | |
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds prettier to the project and applies the formatting changes.
We can probably reduce the diff by setting
trailingComma: "es5". up to you if you want to do that or go with the new formatting (we already have trailing commas everywhere else)