Merged
Conversation
cedric-anne
reviewed
May 14, 2025
a2650c9 to
e6aef9e
Compare
cedric-anne
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
passthru()documentation has been fixed in PHP 8.2. Prior to that, the mention to the the false return value on failure was missing.closes #675
Fix PHPStan error by conditionally passing
$result_codetopassthru()PHPStan reported that
\passthru()never assignsnullto the$result_codeparameter,so the nullable by-ref type caused a mismatch. This fix avoids passing the
$result_codeparameter when it is
null, preventing PHPStan from raising an error while keeping theoptional signature intact.
Big thanks to @cedric-anne for proposing the initial PR.