Fix stream_socket_get_name() on PHP 8.1#683
Merged
silasjoisten merged 1 commit intothecodingmachine:masterfrom May 14, 2025
cedric-anne:fix/stream_socket_get_name
Merged
Fix stream_socket_get_name() on PHP 8.1#683silasjoisten merged 1 commit intothecodingmachine:masterfrom cedric-anne:fix/stream_socket_get_name
stream_socket_get_name() on PHP 8.1#683silasjoisten merged 1 commit intothecodingmachine:masterfrom
cedric-anne:fix/stream_socket_get_name
Conversation
silasjoisten
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function may return a
falsevalue since its first implementation (see php/php-src@1b53a2d#diff-4294bfe38876196fc83b34d3b3a8d16919acbc8aaa68ce2fc77859f0ef46b787R38-R246), but it was missing from the documentation until PHP 8.2 (see php/doc-en@a1702b5).