Skip to content

Ignore the already safe imagesx()/imagesy() functions#669

Merged
silasjoisten merged 1 commit intothecodingmachine:masterfrom
cedric-anne:fix/imagesx-y
May 13, 2025
Merged

Ignore the already safe imagesx()/imagesy() functions#669
silasjoisten merged 1 commit intothecodingmachine:masterfrom
cedric-anne:fix/imagesx-y

Conversation

@cedric-anne
Copy link
Copy Markdown
Contributor

Since PHP 8.0, these functions are throwing TypeError when the first argument is not a GdImage instance. See php/doc-en@0462f49 and php/doc-en@37f858a.

Copy link
Copy Markdown
Collaborator

@silasjoisten silasjoisten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@silasjoisten silasjoisten merged commit 554aeeb into thecodingmachine:master May 13, 2025
10 checks passed
@cedric-anne cedric-anne deleted the fix/imagesx-y branch May 13, 2025 14:20
@silasjoisten
Copy link
Copy Markdown
Collaborator

silasjoisten commented May 13, 2025

released in v3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants