Skip to content

Fix the generation of gmmktime()/mktime() on PHP 8.4+#667

Merged
silasjoisten merged 1 commit intothecodingmachine:masterfrom
cedric-anne:fix/mktime
May 13, 2025
Merged

Fix the generation of gmmktime()/mktime() on PHP 8.4+#667
silasjoisten merged 1 commit intothecodingmachine:masterfrom
cedric-anne:fix/mktime

Conversation

@cedric-anne
Copy link
Copy Markdown
Contributor

The falsy return type was not correctly detected in PHP 8.4+.

See php/doc-en@57e27d2.

Copy link
Copy Markdown
Collaborator

@silasjoisten silasjoisten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! Thanks!

@silasjoisten silasjoisten merged commit 60cdf7c into thecodingmachine:master May 13, 2025
10 checks passed
@cedric-anne cedric-anne deleted the fix/mktime branch May 13, 2025 13:51
@silasjoisten
Copy link
Copy Markdown
Collaborator

released in v3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants