Skip to content

Add l18n handling for Decimal field #1466#1467

Merged
tfranzel merged 1 commit intomasterfrom
decimal_l18n
Nov 1, 2025
Merged

Add l18n handling for Decimal field #1466#1467
tfranzel merged 1 commit intomasterfrom
decimal_l18n

Conversation

@tfranzel
Copy link
Copy Markdown
Owner

@tfranzel tfranzel commented Nov 1, 2025

closes #1466

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.49%. Comparing base (5221afd) to head (d7247a5).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1467   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          76       76           
  Lines        9307     9311    +4     
=======================================
+ Hits         9167     9171    +4     
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tfranzel tfranzel merged commit 62fc98b into master Nov 1, 2025
72 checks passed
@tfranzel tfranzel deleted the decimal_l18n branch November 1, 2025 11:30
@gabn88
Copy link
Copy Markdown

gabn88 commented Nov 1, 2025

You are amazing. What a quick fix.

Just to be sure: does that mean we need to use a different OpenAPI scheme for different languages now? Until now we used one scheme for all languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DecimalField should also support comma-seperated decimals

2 participants