Skip to content

Link to SerializerMethod docs#1377

Merged
tfranzel merged 1 commit intotfranzel:masterfrom
johnthagen:serializer-method-doc-link
Feb 12, 2025
Merged

Link to SerializerMethod docs#1377
tfranzel merged 1 commit intotfranzel:masterfrom
johnthagen:serializer-method-doc-link

Conversation

@johnthagen
Copy link
Copy Markdown
Contributor

Closes #1374

@johnthagen johnthagen changed the title Link to SerializerMethod docs Link to SerializerMethod docs Feb 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (5734744) to head (240d954).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
+ Coverage   98.42%   98.57%   +0.15%     
==========================================
  Files          74       74              
  Lines        9139     9139              
==========================================
+ Hits         8995     9009      +14     
+ Misses        144      130      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnthagen
Copy link
Copy Markdown
Contributor Author

johnthagen commented Feb 4, 2025

@tfranzel The docs aren't super clear (to me) that you can type hint a Serializer rather than a basic type. Should the docs be updated to be more explicit about that / add an example?

@tfranzel tfranzel merged commit f0614aa into tfranzel:master Feb 12, 2025
@johnthagen johnthagen deleted the serializer-method-doc-link branch February 12, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type annotating a recursive serializer

2 participants