Skip to content

chore: use explicit dependency versions instead of refreshVersions#3068

Merged
juherr merged 1 commit intotestng-team:masterfrom
vlsi:versions
Feb 16, 2024
Merged

chore: use explicit dependency versions instead of refreshVersions#3068
juherr merged 1 commit intotestng-team:masterfrom
vlsi:versions

Conversation

@vlsi
Copy link
Copy Markdown
Contributor

@vlsi vlsi commented Feb 15, 2024 •
edited by coderabbitai Bot
Loading

This improves support for Renovatebot and Dependabot

Summary by CodeRabbit

  • New Features
    • Added version specification for a plugin to enhance build process stability.
  • Bug Fixes
    • Updated various dependencies across the project to improve compatibility and resolve potential vulnerabilities.
  • Chores
    • Removed an unused plugin to streamline the build configuration.
  • Documentation
    • No visible changes to end-users.

@vlsi
chore: use explicit dependency versions instead of refreshVersions
d533a88 
This improves support for Renovatebot and Dependabot
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 15, 2024 •
edited
Loading

Walkthrough

This update focuses on enhancing library dependencies across various components of the project. Key updates include the advancement of the assertj-core library, adjustments in plugin configurations, and the removal of the de.fayard.refreshVersions plugin. Significant dependency updates were made in the testng-core, testng-core-api, and other modules, improving tools like SpotBugs, Guice, and SLF4J. These changes aim to refine the project's stability, performance, and compatibility with recent software versions.

Changes

File Path Change Summary
.../testng.testing.gradle.kts, testng-ant/..., testng-core-api/..., testng-core/..., testng-runner-api/..., testng-test-osgi/..., testng/testng-build.gradle.kts Updated various dependencies (e.g., assertj-core, Apache Ant, SpotBugs, Guice, SLF4J, JCommander, SnakeYAML, jQuery, Groovy, Beanshell, Mockito Core, ShrinkWrap, XMLUnit AssertJ, JLibs Core, Heaplib, Jvm-attach-api, Commons-IO).
build.gradle.kts Added version specification to com.github.vlsi.stage-vote-release plugin.
settings.gradle.kts Removed de.fayard.refreshVersions plugin.

🐇✨

In the garden of code, where dependencies intertwine,
A rabbit hopped through, making everything fine.
"Update, refine," it whispered with glee,
Libraries and plugins, as fresh as can be.
🌟 With every hop, a bug squashed, a version new,
This rabbit's work, a craft so true.
🎉 To celebrate the changes, with joy we convene,
In a world more stable, efficient, and clean.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai Bot reviewed Feb 15, 2024
View reviewed changes
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 196babc and d533a88.
Files selected for processing (9)
  • build-logic/code-quality/src/main/kotlin/testng.testing.gradle.kts (1 hunks)
  • build.gradle.kts (1 hunks)
  • settings.gradle.kts (1 hunks)
  • testng-ant/testng-ant-build.gradle.kts (1 hunks)
  • testng-core-api/testng-core-api-build.gradle.kts (1 hunks)
  • testng-core/testng-core-build.gradle.kts (1 hunks)
  • testng-runner-api/testng-runner-api-build.gradle.kts (1 hunks)
  • testng-test-osgi/testng-test-osgi-build.gradle.kts (1 hunks)
  • testng/testng-build.gradle.kts (1 hunks)
Files skipped from review due to trivial changes (2)
  • build.gradle.kts
  • settings.gradle.kts
Additional comments: 33
testng-runner-api/testng-runner-api-build.gradle.kts (1)
  • 7-7: LGTM!
testng-ant/testng-ant-build.gradle.kts (2)
  • 6-6: LGTM!
  • 10-10: LGTM!
testng-core-api/testng-core-api-build.gradle.kts (4)
  • 13-13: LGTM!
  • 14-14: LGTM!
  • 18-18: LGTM!
  • 19-19: LGTM!
build-logic/code-quality/src/main/kotlin/testng.testing.gradle.kts (1)
  • 9-9: LGTM!
testng-core/testng-core-build.gradle.kts (15)
  • 32-32: LGTM!
  • 33-33: LGTM!
  • 35-35: LGTM!
  • 37-37: LGTM!
  • 42-42: LGTM!
  • 44-44: LGTM!
  • 47-47: LGTM!
  • 48-48: LGTM!
  • 49-49: LGTM!
  • 50-50: LGTM!
  • 51-51: LGTM!
  • 52-52: LGTM!
  • 53-53: LGTM!
  • 54-54: LGTM!
  • 55-55: LGTM!
testng/testng-build.gradle.kts (2)
  • 21-21: LGTM!
  • 25-25: LGTM!
testng-test-osgi/testng-test-osgi-build.gradle.kts (8)
  • 21-21: LGTM!
  • 25-25: LGTM!
  • 28-28: LGTM!
  • 29-29: LGTM!
  • 30-30: LGTM!
  • 31-31: LGTM!
  • 32-32: LGTM!
  • 33-33: LGTM!

juherr
juherr reviewed Feb 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think gradle plugins for dependency management are useless now?
And what do you think about the catalog?

@vlsi
Copy link
Copy Markdown
Contributor Author

vlsi commented Feb 15, 2024

Do you think gradle plugins for dependency management are useless now?

As Dependabot / Renovatebot could create PRs, they are much better to maintain than manually creating PRs.
I'm not sure re Dependabot, however, for Renovate one can configure the update rules to group certain dependencies. See https://github.com/apache/jmeter/blob/09c3f810dda7efaf1510ac062454d978d90a0741/renovate.json

Gradle plugins might be useful for in-house development, however, I do not see much value for public GitHub projects.

And what do you think about the catalog?

I have not tried it much.
There's an on-going issue re catalog + precompiled plugins (~build-logic) gradle/gradle#15383

@juherr juherr merged commit 2d0c022 into testng-team:master Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@juherr juherr juherr approved these changes

@krmahadevan krmahadevan Awaiting requested review from krmahadevan krmahadevan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlsi @juherr