Dont honour params specified in suite-file tag#2923
Merged
krmahadevan merged 1 commit intotestng-team:masterfrom Jun 8, 2023
Merged
Dont honour params specified in suite-file tag#2923krmahadevan merged 1 commit intotestng-team:masterfrom
krmahadevan merged 1 commit intotestng-team:masterfrom
Conversation
juherr
requested changes
Jun 7, 2023
Member
juherr
left a comment
There was a problem hiding this comment.
The dtd file should be updated to be synch to the behavior
Member
Author
I would need help with that, because I have never done that. Also how do we go about publishing this ? |
Member
|
I checked and confirm that the issue is in the dtd file: According to the spec, The dtd files are hosted here: https://github.com/testng-team/testng-team.github.io |
Member
Author
|
@juherr - The DTD is fixed as part of this PR testng-team/testng-team.github.io#46 Can we go ahead with merging this PR ? |
0ac19c0 to
c8bfea8
Compare
Closes testng-team#581 TestNG does not have any logic that would honour parameter tags specified within suite-files tag. But due to a parsing bug, we end up reading parameters that were specified within `<suite-file>` tag. This tag by definition is NOT meant to have any child tags inside of it. Fixed this discrepancy by adding a warning when this anomaly is detected and skipping of reading the `<parameter>` tag inside it as if it were specified within `<suite>` tag.
juherr
reviewed
Jun 7, 2023
Member
juherr
left a comment
There was a problem hiding this comment.
LGTM. Just be sure that the new dtd version works well together with the previous one
juherr
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #581
TestNG does not have any logic that would
honour parameter tags specified within suite-files tag. But due to a parsing bug, we end up reading
parameters that were specified within
<suite-file>tag.This tag by definition is NOT meant to have any
child tags inside of it.
Fixed this discrepancy by adding a warning when
this anomaly is detected and skipping of reading
the
<parameter>tag inside it as if it werespecified within
<suite>tag.Fixes #581 .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.