Skip to content

GITHUB-2888 - don't fail test with dataProvider if skipped#2889

Merged
krmahadevan merged 2 commits intotestng-team:masterfrom
jmoreira18:GITHUB-2888
Mar 23, 2023
Merged

GITHUB-2888 - don't fail test with dataProvider if skipped#2889
krmahadevan merged 2 commits intotestng-team:masterfrom
jmoreira18:GITHUB-2888

Conversation

@jmoreira18
Copy link
Copy Markdown
Contributor

Fixes #2888

If you want to create a listener that would skip a DataProvider in case a Test will be skipped, the Test was marked as FAILED, instead of SKIPPED

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

Copy link
Copy Markdown
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the contribution 👍

Comment thread testng-core/src/test/java/test/dataprovider/issue2888/SkipDataProviderTest.java Outdated
@jmoreira18 jmoreira18 requested review from juherr and removed request for krmahadevan March 22, 2023 17:09
@krmahadevan krmahadevan merged commit ff5843a into testng-team:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skipped Tests with DataProvider appear as failed

3 participants