feat: add TypeScript types#963
Merged
Belco90 merged 1 commit intotesting-library:mainfrom Nov 20, 2024
G-Rath:add-types
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 96.23% 96.33% +0.09%
==========================================
Files 44 46 +2
Lines 2419 2481 +62
Branches 1000 1028 +28
==========================================
+ Hits 2328 2390 +62
Misses 91 91 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Belco90
approved these changes
Nov 20, 2024
Member
|
Thanks! I'll autogenerate this with tsup when I finish my pending task for setting up a proper bundle to export CJS and ESM formats. |
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
eslint.config.jsin TypeScript codebases don't result in errorsContext
Now that plugins are imported "naturally" they can be type-checked by TypeScript so it's useful to ship types - for now I've just manually typed the plugin since primarily the only useful thing to have typed is the configs, as things like rules and settings are still not implicitly inferred and trying to automate this would be overkill.
These types match those that we've got in
eslint-plugin-jest,eslint-plugin-jest-dom, and other places