test: run against ESLint v9#926
Merged
Belco90 merged 8 commits intotesting-library:mainfrom Oct 18, 2024
G-Rath:test-v9
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
==========================================
+ Coverage 96.23% 96.33% +0.09%
==========================================
Files 44 46 +2
Lines 2419 2481 +62
Branches 1000 1028 +28
==========================================
+ Hits 2328 2390 +62
Misses 91 91 ☔ View full report in Codecov by Sentry. |
This was referenced Aug 14, 2024
Merged
Belco90
reviewed
Oct 17, 2024
Member
Belco90
left a comment
There was a problem hiding this comment.
The changes LGTM, but I'll give it another review after being rebased.
MichaelDeBoey
previously approved these changes
Oct 17, 2024
Member
MichaelDeBoey
left a comment
There was a problem hiding this comment.
Some minor tweaks to the comments to make them consistent all over the place, but nothing big
MichaelDeBoey
approved these changes
Oct 17, 2024
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
Changes
eslint-plugin-jest,eslint-plugin-jest-dom, andeslint-plugin-jest-extendedwith great successfulContext
Before saying the plugin officially supports ESLint v9, it should be testing against v9 which in turn requires accounting for v9's defaulting to flat config and the improvements that have been made to the rule tester to help plugin authors catch bugs.
Besides flat config in general, the two notable changes to the rule tester that require changes to this test suite are:
outputthat matchescodeThere's only a couple of occurrences of that first one and the fix is to just specify
nullinstead which means "this rule supports autofix, but for this test case it does not do anything".The second though requires a lot more work especially because of how much mapping this test suite does meaning addressing them in full would have huge changes to the layout so instead for now I've made all the tests unique typically by adding a comment that mentions the testing framework whose loop they're part of - ideally though a number of these tests should be restructured to pull such cases out of the mapping loops, which is something I'm happy to help with via follow-up and parallel PRs.
I have also cherry-picked the straightforward removal of a number of duplicates into #927 which if landed first would help reduce the overall diff of this pull request.