Add username option to Valkey container#1117
Merged
cristianrgreco merged 4 commits intotestcontainers:mainfrom Aug 28, 2025
Merged
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cristianrgreco
approved these changes
Aug 28, 2025
Contributor
Author
|
Hey @cristianrgreco ✋ I was wondering if you have any plans for the next release, as I’d love to use the changes from my recent contribution. |
Collaborator
|
Hey @rqbazan, apologies for the delay I've been away for the last week. I'm going to cut a release today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hey there! ✋
I made a small change to the Valkey test container to allow passing a
usernameoption. Right now, my workaround is to create a generic container like this:But would be nice if
@testcontainers/valkeysupport this nativelyChanges
withUsernamemethod to ValkeyContainer--userif username was provided